BUG/TST: fillna limit checks and tests #27077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reversed the order of returning and performing checks on `limit` in fillna method in blocks.py so that an ValueError is raised before returning.
jreback
requested changes
Jun 27, 2019
Inevitable-Marzipan
changed the title
DataFrame.fillna limit checks and tests
Codecov Report
@@ Coverage Diff @@
## master #27077 +/- ##
===========================================
- Coverage 92.03% 41.86% -50.18%
===========================================
Files 180 180
Lines 50714 50714
===========================================
- Hits 46675 21229 -25446
- Misses 4039 29485 +25446
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #27077 +/- ##
==========================================
- Coverage 92.04% 92.03% -0.01%
==========================================
Files 180 180
Lines 50714 50718 +4
==========================================
Hits 46680 46680
- Misses 4034 4038 +4
Continue to review full report at Codecov.
|
2 tasks
Co-Authored-By: William Ayd <[email protected]>
jreback
approved these changes
Jun 27, 2019
WillAyd
approved these changes
Jun 27, 2019
|
Thanks @Inevitable-Marzipan ! |
|
Thanks for the help guys, 1st PR done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reversed the order of returning and performing checks on
limitin fillna method in blocks.py so that an ValueError is raised
before returning.
Alternative to PR #27074
git diff upstream/master -u -- "*.py" | flake8 --diff